Skip to content

Conversation

TimPansino
Copy link
Contributor

@TimPansino TimPansino commented Sep 29, 2025

Overview

  • Delete placeholder benchmark file.
  • Add benchmark file for all relevant public APIs in newrelic.agent.
    • Note: There are a couple TODOs that are marked out, those will need to be fixed in the future to fully cover newrelic.agent.
  • Tweak behavior of developer mode and OTLP to allow benchmarking record_dimensional_metric[s].

@TimPansino TimPansino requested a review from a team as a code owner September 29, 2025 20:45
Copy link

github-actions bot commented Sep 29, 2025

MegaLinter analysis: Success

Descriptor Linter Files Fixed Errors Warnings Elapsed time
✅ ACTION actionlint 7 0 0 1.01s
✅ MARKDOWN markdownlint 7 0 0 0 1.42s
✅ PYTHON ruff 946 0 0 0 1.11s
✅ PYTHON ruff-format 946 0 0 0 0.35s
✅ YAML prettier 15 0 0 0 1.52s
✅ YAML v8r 15 0 0 5.75s
✅ YAML yamllint 15 0 0 0.65s

See detailed reports in MegaLinter artifacts

MegaLinter is graciously provided by OX Security

@mergify mergify bot added the tests-failing Tests failing in CI. label Sep 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.62%. Comparing base (92698ac) to head (6211fb5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
newrelic/core/config.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1524   +/-   ##
=======================================
  Coverage   81.61%   81.62%           
=======================================
  Files         207      207           
  Lines       23909    23913    +4     
  Branches     3789     3790    +1     
=======================================
+ Hits        19514    19519    +5     
+ Misses       3123     3122    -1     
  Partials     1272     1272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Sep 29, 2025
@TimPansino TimPansino enabled auto-merge (squash) October 4, 2025 00:26
@mergify mergify bot added tests-failing Tests failing in CI. and removed tests-failing Tests failing in CI. labels Oct 4, 2025
pass

@background_task()
def bench_record_llm_feedback_event(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason these were not being run with test data?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must have lost that commit when rebasing. Fixed this and added the API calls back here.

@TimPansino TimPansino force-pushed the feat-agent-api-benchmarks branch from da57c9c to 3a72e82 Compare October 9, 2025 22:00
@mergify mergify bot added the tests-failing Tests failing in CI. label Oct 9, 2025
@TimPansino TimPansino merged commit ea44e9d into main Oct 10, 2025
103 of 105 checks passed
@TimPansino TimPansino deleted the feat-agent-api-benchmarks branch October 10, 2025 20:48
@mergify mergify bot removed the tests-failing Tests failing in CI. label Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants